Skip to content

Add delimiters to product analytics single stat visualizations

What does this MR do and why?

This MR adds the new useDelimiters property to the Product Analytics single stat visualizations.

This means that once a value exceeds > 999 or contains a decimal, the value will be formatted based upon the browsers locale.

Locale Output
[Before] 10000.75
en-US (US) 10,000.75
de-DE (German) 10.000,75

Screenshots or screen recordings

Before After (US) After (DE)
image image image

How to set up and validate locally

  1. Follow these instructions to set up Product Analytics in GDK.
  2. Onboard Product Analytics by setting up the feature at Project > Analytics > Analytics dashboards.
  3. Visit a dashboard such as Behavior.
  4. Verify that the single stat values are shown correctly.
  5. Bonus verifications:
    1. Add enough data to generate grouped numbers and validate the correct group delimiter is used for your locale.
    2. Change your browsers locale and test that the group delimiter matches that locale.
      • I had to change my system locale for Chrome to accept my new language 🙈
        image

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Robert Hunt

Merge request reports

Loading