Add popover for branch modification setting
What does this MR do and why?
Add popover for branch modification setting
- add learn more link
- add button to permanently dismiss the popover
- add tests
Changelog: added
EE: true
Screenshots or screen recordings
Screenshots are required for UI changes, and strongly recommended for all other merge requests.
Before | After |
---|---|
No popover |
How to set up and validate locally
Numbered steps to set up and validate the change are strongly suggested.
echo "Feature.enable(:scan_result_policy_settings)" | rails c
- Upload a GitLab Ultimate license
- Navigate to a project/group => Secure => Policies => New policy => Scan Result Policy
- Verify "All protected branches" is selected by default and the
Prevent branch protection modification
setting is selected - Deselect
Prevent branch protection modification
- Verify popover appears
- Switch from "All protected branches"
- Verify popover disappears
- Switch back to "All protected branches"
- Verify popover appears
- Select the checkbox
- Verify popover disappears
- Navigate to yaml mode, switch yaml to disable the setting, navigate back to rule mode
- Verify the popover appears
- Click the
Learn more
link - Verify user is navigated to https://docs.gitlab.com/ee/user/application_security/policies/scan-result-policies.html
- Click the
Don't tell me this again
button - Verify user is never notified again
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Related to #418766 (closed)
Edited by Alexander Turinske