Skip to content

Group Project Approval Settings for scan result policy

Artur Fedorov requested to merge 418765-policies-merge-requests-settings-accordion into master

What does this MR do and why?

This MR resolves #418765 (closed) and !130880 (comment 1550562877)

This MR groups settings by logical area in accordion instead of flat list

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

Before After
project_level_settings.mov group settings.mov

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

  1. Enable feature flag
Feature.enable(:scan_result_policy_settings)
  1. Go to project or group
  2. Secure -> Policies -> New policy -> new scan result policy
  3. See default settings on bottom
  4. Select any merge request rule -> check if settings are changed to any merge request specific settings
  5. New settings should be visible if at least one of selected rules is any merge request rule
  6. Make sure settings are grouped in accordion

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Related to #418765 (closed)

Edited by Artur Fedorov

Merge request reports