Skip to content

Create service accounts as external in one query

Drew Blessing requested to merge dblessing_create_sa_external_simplify into master

What does this MR do and why?

Currently we have two queries when creating a service account. One to create the user and then one to update it as external. This change allows the external attribute to be passed to the Authorized(Create/Build)Service so we can create the service account user as external from the beginning.

There's no issue associated with this change. I just noticed the double query when reviewing !131238 (comment 1557245683) and decided to improve it while I was thinking about it.

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

Before After

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Drew Blessing

Merge request reports