Refactor OldestPerCommitFinder spec
What does this MR do and why?
While testing !131407 (merged), I noticed this old spec that was creating extraneous merge_request_diff records. This caused problems in !131407 (merged) due to the created diffs not being backed by actual records (needed when creating patch_id shas for fingerprinting diffs - &10249 (closed)). Removing the extraneous record creation and using the merge_request_diff that is created as part of the MR itself (as the newly created record has additional information beyond that of the original merge_request_diff) allows these specs to continue to pass while improving their overall performance by reducing the number of queries executed.
Screenshots or screen recordings
Screenshots are required for UI changes, and strongly recommended for all other merge requests.
| Before | After |
|---|---|
How to set up and validate locally
Numbered steps to set up and validate the change are strongly suggested.
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Related to #424542 (closed)