Skip to content

Fixing import list pagination bug

Max Fan requested to merge 383851-import-group-pagination into master

What does this MR do and why?

Currently there's a minor bug where going to page 2 and switching per_page to 50 returns no records found, even when there are records.

This switches the behaviour to going back to page 1 whenever the per_page is changed.

This change is for both the import page

as well as the import history page

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

Before

After

See the video in the correlated issue

Screen Recording 2023-09-19 at 1.27.22 PM.mov

Also for the project history page:

Screen Recording 2023-09-19 at 1.28.36 PM.mov

How to set up and validate locally

  1. On the direct transfer page, have more than 20 groups
  2. Navigate to page 2 and switching per_page should bring you back to page 1

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Related to #383851 (closed)

Edited by Max Fan

Merge request reports

Loading