Fail patch-package on incorrectly versioned patches
What does this MR do and why?
Fail patch-package on warnings
This upgrades patch-package to the latest version. The key feature
wanted was the addition of the --error-on-warn
flag, added in 6.5.0
via https://github.com/ds300/patch-package/pull/345.
This allows us to ensure that patch files are always kept up-to-date, which is easy to miss during Rails upgrades.
Bump @rails/ujs patch
This fixes a warning from patch-package about an old patch version.
This is a follow up to
!132044 (merged), that caused
this warning on running yarn install
:
Warning: patch-package detected a patch file version mismatch
Don't worry! This is probably fine. The patch was still applied
successfully. Here's the deets:
Patch file created for
@rails/ujs@7.0.6
applied to
@rails/ujs@7.0.8
At path
node_modules/@rails/ujs
This warning is just to give you a heads-up. There is a small chance of
breakage even though the patch was applied successfully. Make sure the package
still behaves like you expect (you wrote tests, right?) and then run
patch-package @rails/ujs
to update the version in the patch file name and make this warning go away.
Screenshots or screen recordings
n/a
How to set up and validate locally
- Run
yarn install
. - Confirm no warning is shown.
- Revert the commit to bump the patch (
git revert @
) - Run
yarn install
- Confirm the warning is shown, and that the process exits with a non-zero status.
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Edited by Mark Florian