Remove default application/json header from BulkImports::Clients::HTTP
What does this MR do and why?
This MR removes the default Content-Type
header with the value of application/json
from the BulkImports:: Clients::HTTP
class.
This change was needed to fix the Invalid content type
bugfunctional with GSP when proxy_download
is set to false
.
Relates to: https://gitlab.com/gitlab-org/gitlab/-/issues/383767
Screenshots or screen recordings
Before | After |
---|---|
How to set up and validate locally
- Checkout the
bmarjanovic-georgekoltsov/bulk-imports-http-client-header
branch - Configure the object storage
- Set proxy-download to
false
in theconfig/gitlab.yml
file - Validate that import works successfully with both OS providers.
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Edited by Bojan Marjanovic