Skip to content

Use GDK's .tool-version as canonical settings in build-gdk-image

Stan Hu requested to merge sh-use-gdk-tool-versions into master

What does this MR do and why?

The build-gdk-image job attempts to install GitLab with a given GDK version. When the GDK and GitLab .tool-versions diverge in PostgreSQL versions, commands such as psql will fail to run since the GDK will install one set of PostgreSQL versions while GitLab expects another.

To avoid build failures that result from this, use the GDK .tool-versions as the canonical file by copying it into the gitlab directory since that's what's actually installed.

This will help avoid causing broken master builds whenever .tool-versions change.

Relates to gitlab-org/quality/engineering-productivity/master-broken-incidents#3660 (closed)

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

Before After

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Stan Hu

Merge request reports

Loading