Skip to content

New navigation remove list marker and href attribute

Scott de Jonge requested to merge super-sidebar-html-fixes into master

What does this MR do and why?

  • Remove list marker from pinned items <ul> items
  • Remove href attribute from <counter>

Screenshots or screen recordings

Before After
CleanShot_2023-09-28_at_11.34.42_2x CleanShot_2023-09-28_at_11.34.04_2x
CleanShot_2023-09-28_at_11.30.33_2x CleanShot_2023-09-28_at_11.30.16_2x

How to set up and validate locally

  1. Inspect "Pinned items" list in new navigation (Projects/Groups navigation) there shouldn't be a ::marker pseduo element for each <li>
  2. Inspect "Merge requests" <counter> button in new navigation, there shouldn't be an empty href attribute

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Scott de Jonge

Merge request reports