Skip to content

Fix dropdown alignment in new navigation

Scott de Jonge requested to merge super-sidebar-dropdown-offsets into master

What does this MR do and why?

Fix dropdown alignment in new navigation

Adjust 2px on dropdown offsets to compensate for gl-gap-1 on parent:

  1. Add 2px to IMPERSONATING_OFFSET to compensate for space
  2. Remove 2px from "Create new..." menu dropdown default offset to compensate for space

Changelog: fixed

Screenshots or screen recordings

Before After
gdk.test_3000_flightjs_Flight_-_merge_requests_10 gdk.test_3000_flightjs_Flight_-merge_requests_10__2
gdk.test_3000_flightjs_Flight_-merge_requests_10__1 gdk.test_3000_flightjs_Flight_-merge_requests_10__3
gdk.test_3000_-profile_preferences__2 gdk.test_3000_-profile_preferences__1
gdk.test_3000_-profile_preferences__3 gdk.test_3000_-_profile_preferences

How to set up and validate locally

  1. Default should be aligned center
    1. Toggle "Create new..." dropdown
    2. Toggle user's menu dropdown
  2. When impersonating a user should be aligned center
    1. Toggle "Create new..." dropdown
    2. Toggle user's menu dropdown

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Scott de Jonge

Merge request reports