Skip to content

Add a QA test for malformed URLs

Stan Hu requested to merge sh-add-qa-for-malformed-url into master

What does this MR do and why?

Because of https://github.com/puma/puma/pull/3094, Puma v6.4.0 returns the status code sent from the low-level handler instead of Puma's recommended status code. This caused malformed URLs to return a 500 error when previously it would return a 400 Bad Request error, which skewed error metrics.

To catch this issues in the future, add a gitlab-qa test that attempts to issue a malformed URL.

Relates to gitlab-com/gl-infra/production#16417 (closed)

How to set up and validate locally

In the qa directory, run:

QA_GITLAB_URL=https://gitlab.com bundle exec rspec qa/specs/features/api/3_create/merge_request/view_merge_requests_spec.rb

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Stan Hu

Merge request reports

Loading