Fix propagate integration logic for enum fields
requested to merge bmarjanovic/instance-level-setting-has-no-effect-whether-we-use-comment-settings-standard-or-comment into master
What does this MR do and why?
This MR fixes the typebug from #355610 (closed).
The main change is in the integration#to_database_hash
method, and now we're using attributes_for_database
method to preserve database values for enum
fields. The rest of the changes, are pure mr refactor.
Screenshots or screen recordings
Setup | Screenshot |
---|---|
With multi-line commit message |
How to set up and validate locally
steps-to-reproduce
Follow the steps defined in the issue:note: You can also validate that new Integrations::Jira
instances have the correct comment_detail
attribute inherited from the instance-level integration.
After setting up an instance-level Jira integration, check that the comment_detail
value is propagated to project and group integrations created under it.
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Related to #355610 (closed)
Edited by Bojan Marjanovic