Skip to content

Parsing timeout_timer argument for advanceStageWorker

Max Fan requested to merge parsing_time_for_timeout into master

What does this MR do and why?

Currently there is a bug https://log.gprd.gitlab.net/app/r/s/IVpHc as sidekiq will transform the timeout argument into a string one. This will break the worker

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

Before After

How to set up and validate locally

  1. Checkout this branch
  2. Set AdvanceStage::TIMEOUT_DURATION to 2.minutes. Change if new_waiters.empty? -> if new_waiters.empty? && false so it doesn't execute
  3. Running github import will fail the import or move to next stage if done optimistically

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Max Fan

Merge request reports