Aligns upgrade badge to the surrounding text
What does this MR do and why?
Aligns upgrade badge to the surrounding text
Changelog: changed
Screenshots or screen recordings
Notice the alignment of the badge:
Before | After |
---|---|
How to set up and validate locally
Unless you have some outdated runners, it may be hard to downgrade your runners. We can simply change the data to force a change:
- While running GitLab Ultimate license
- Edit the following file to return either
:available
or:recommended
as upgrade status
diff --git a/ee/app/graphql/ee/types/ci/runner_type.rb b/ee/app/graphql/ee/types/ci/runner_type.rb
index 34757f57f97d..a9afea1e7321 100644
--- a/ee/app/graphql/ee/types/ci/runner_type.rb
+++ b/ee/app/graphql/ee/types/ci/runner_type.rb
@@ -25,6 +25,7 @@ module RunnerType
alpha: { milestone: '14.10' }
def upgrade_status
+ return :available
return unless upgrade_status_available?
BatchLoader::GraphQL.for(object.id).batch(key: :upgrade_status) do |runner_ids, loader|
- Log in as admin
- Visit the Admin -> Runners page (http://gdk.test:3000/admin/runners/)
- Pick any runner to see it's details by clicking on the runner name
- Confirm the alter is not there, as the badge contains the required information
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Related to #423770 (closed)