Protected containers: Graphql mutation for creating protection rules
requested to merge gitlab-community/gitlab:427547-protected-containers-graphql-mutation-create-container-registry-protection-rule into master
What does this MR do and why?
- This MR adds a new graphql endpoint for creating container registry protection rule
- This MR is part of the EPIC &9825 and is planned to be included in the 1st version of this feature, see &9825 (comment 1461465889)
- This MR intends to follow the implementation the MR for the feature "protected packages", see Protected packages: Add model and migration for... (!124776 - merged)
Screenshots or screen recordings
With this MR, it is possible to send graphql requests in order to create new container registry protection rules.
The body of the graphql request looks like this
mutation {
createContainerRegistryProtectionRule(
input: {
projectPath: "flightjs/Flight"
containerPathPattern: "@flight/flight-*"
pushProtectedUpToAccessLevel: MAINTAINER
deleteProtectedUpToAccessLevel: OWNER
}
) {
containerRegistryProtectionRule {
id
containerPathPattern
pushProtectedUpToAccessLevel
deleteProtectedUpToAccessLevel
}
errors
}
}
How to set up and validate locally
- Enable feature flag via
rails c
Feature.enable(:container_registry_protected_containers)
- Now, you should be able to send mutation requests via the graphql api
curl --request POST \
--url http://gdk.test:3000/api/graphql \
--header 'Authorization: Bearer ypCa3Dzb23o5nvsixwPA' \
--header 'Content-Type: application/json' \
--cookie 'perf_bar_enabled=true; BetterErrors-2.10.1-CSRF-Token=0b882179-5e4a-431b-a420-2be3701cece8' \
--data '{"query":"mutation {\n\tcreateContainerRegistryProtectionRule(\n\t\tinput: {\n\t\t\tprojectPath: \"flightjs/Flight\"\n\t\t\tcontainerPathPattern: \"@flight/flight-*\"\n\t\t\tpushProtectedUpToAccessLevel: MAINTAINER\n\t\t\tdeleteProtectedUpToAccessLevel: OWNER\n\t\t}\n\t) {\n\t\tcontainerRegistryProtectionRule {\n\t\t\tid\n\t\t\tcontainerPathPattern\n\t\t\tpushProtectedUpToAccessLevel\n\t\t\tdeleteProtectedUpToAccessLevel\n\t\t}\n\t\terrors\n\t}\n}\n"}'
Todos
-
Think about removing code duplication -
Think about extracting common functionality from package protection rules -
Please create feature flag roll out issue, see #429074
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR. -
Changelog entry added, if necessary -
Documentation created/updated via this MR -
Documentation reviewed by technical writer or follow-up review issue created -
Tests added for this feature/bug -
Tested in all supported browsers -
Conforms to the code review guidelines -
Conforms to the merge request performance guidelines -
Conforms to the style guides -
Conforms to the javascript style guides -
Conforms to the database guides -
Wait for MR to be merged: Protected containers: Add basic model and migra... (!133297 - merged)
-
Related to #427547 (closed)
Edited by Gerardo Navarro