Resolve "Nav eval > Unauthenticated nav landmark"
What does this MR do and why?
Wrap the logged out top bar navigation in a <nav>
element and give it a meaningful name with aria-label
as <nav aria-label="Explore GitLab">
.
Screenshots or screen recordings
Before | After |
---|---|
How to set up and validate locally
- Open GDK in incognito window
- Go to publically accessible page e.g. http://gdk.test:3000/flightjs/Flight/-/merge_requests/4
- Review logged out marketing header accessibility tree (Chrome | Firefox)
-
<nav>
witharia-label="Explore GitLab"
should provide "navigation Explore GitLab" node
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Related to #426749 (closed)
Edited by Scott de Jonge