Skip to content

Resolve "Nav eval > Unauthenticated nav landmark"

What does this MR do and why?

Wrap the logged out top bar navigation in a <nav> element and give it a meaningful name with aria-label as <nav aria-label="Explore GitLab">.

Screenshots or screen recordings

Before After
CleanShot_2023-10-09_at_15.34.41_2x CleanShot_2023-10-09_at_16.06.00_2x
CleanShot_2023-10-09_at_15.42.21_2x CleanShot_2023-10-09_at_16.05.29_2x

How to set up and validate locally

  1. Open GDK in incognito window
  2. Go to publically accessible page e.g. http://gdk.test:3000/flightjs/Flight/-/merge_requests/4
  3. Review logged out marketing header accessibility tree (Chrome | Firefox)
  4. <nav> with aria-label="Explore GitLab" should provide "navigation Explore GitLab" node

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Related to #426749 (closed)

Edited by Scott de Jonge

Merge request reports

Loading