Remove system_usage_data_monthly from usage_data.rb
What does this MR do and why?
Related to #421506 (closed)
We want to move some metrics from usage_data.rb into metric definitions.
Screenshots or screen recordings
Screenshots are required for UI changes, and strongly recommended for all other merge requests.
Before | After |
---|---|
How to set up and validate locally
To test this, we need to make sure that the metrics work the same as before.
- While on
master
branch, open the rails console and generate a service ping:sp = Gitlab::Usage::ServicePingReport.for(output: :all_metrics_values)
- Check out this MR's branch and run
reload!
in the rails console - Generate a new service ping:
sp2 = Gitlab::Usage::ServicePingReport.for(output: :all_metrics_values)
- We should have the same metric values for the updated metrics:
sp['counts_monthly'] == sp2['counts_monthly']
should returntrue
.
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Edited by Michał Wielich