Skip to content

Update scan result drawer to not require actions

Alexander Turinske requested to merge 421920-update-policy-drawer into master

What does this MR do and why?

Update scan result drawer to not require actions

  • make actions not required
  • add conditionals for action yaml
  • show updated text if no approvals are required
  • update tests

Changelog: changed

EE: true

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

Scenario Before After
Has approvers some_-_b No change
No change blank zero_-_a

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

  1. Upload a GitLab Ultimate license
  2. Navigate to a project/group => Secure => Policies => New policy => Scan Result Policy => Yaml mode => Insert the below yaml => Create policy
type: scan_result_policy
name: Settings only / No Actions
description: ''
enabled: false
rules:
  - type: license_finding
    branches: []
    match_on_inclusion: true
    license_types:
      - Abstyles License
    license_states:
      - newly_detected
      - detected
approval_settings:
  block_protected_branch_modification:
    enabled: true
  1. Navigate to the project/group => Secure => Policies => Select new policy
  2. Verify that policy drawer is not blank

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Related to #421920 (closed)

Edited by Alexander Turinske

Merge request reports

Loading