Skip to content

Migrates the milestone combobox to GlListbox

Sam Beckham requested to merge 413500-milestone-combobox into master

What does this MR do and why?

Migrates the milestone combobox to GlListbox

Deletes the old dropdown and uses a pajamas compliant GlCollapsibleListbox

Note: The reset button only appears once all the milestones have been selected. This is a bug in GitLab UI that has been addressed in gitlab-ui!3737 (merged)

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

Before After
Screen_Recording_2023-10-13_at_10.06.03 Screen_Recording_2023-10-13_at_13.54.47
Screenshot_2023-10-13_at_10.02.42 Screenshot_2023-10-16_at_11.18.51
Screenshot_2023-10-13_at_10.02.46 Screenshot_2023-10-16_at_11.19.10
Screenshot_2023-10-13_at_10.02.58 Screenshot_2023-10-16_at_11.19.33
Screenshot_2023-10-13_at_10.03.06 Screenshot_2023-10-16_at_11.19.41

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

  1. On a project, go to Deploy > Releases
  2. Create a new release
  3. You should see the milestone select dropdown on this page
  4. If the dropdown doesn't have any milestones, make sure to add some to the appropriate group and/or project

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Related to #413500 (closed)

Edited by Sam Beckham

Merge request reports

Loading