Skip to content

Fix dark mode projects.scss colors - regression

Deepika Guliani requested to merge dg-fix-dark-mode-projects-color into master

What does this MR do and why?

Details mentioned in #239865 (comment 1605157055)

This MR fixes a regression caused by Import missing projects specific CSS on more li... (!131405 - merged). Even though the changes are behind an FF , the dark mode vars were left when moving to page_bundles projects.scss. The changes here will make sure that all colors are calculated according to the mixin depending on the mode.

Changelog: fixed

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

Before After
Screenshot_2023-10-17_at_10.19.45_AM Screenshot_2023-10-17_at_10.03.36_AM
Screenshot_2023-10-17_at_10.19.56_AM Screenshot_2023-10-17_at_10.22.42_AM

How to set up and validate locally

In addition to all paths being checked in the original MR , please check project detail page in both dark mode and light mode

Project detail page http://127.0.0.1:3000/flightjs/another-one-block-ror

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Deepika Guliani

Merge request reports

Loading