Skip to content

Format CI/CD analytics metrics using the browser settings

Alex Pennells requested to merge 420823-improve-number-formatting into master

What does this MR do and why?

Format CI/CD analytics metrics using the browser settings (adds delimiters based on user prefs)

The changes to metric_tile.vue will affect other apps as well, but the difference is minimal so I opted to change the formatting across all use-cases

Screenshots or screen recordings

Before After
Screenshot_2023-10-19_at_9.43.28_PM Screenshot_2023-10-19_at_9.43.16_PM
Screenshot_2023-10-19_at_9.44.46_PM Screenshot_2023-10-19_at_9.44.34_PM

How to set up and validate locally

  • Visit CI/CD analytics page for any project gdk.test:3000/flightjs/Flight/-/pipelines/charts?chart=pipelines
  • View the metric values (data can easily be mocked by updating these lines to static values
  • Click the Deployment frequency tab
  • View the Deploys/Deployment Frequency metric tiles (data can easily be mocked by updating this line to a static value)

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Related to #420823 (closed)

Edited by Alex Pennells

Merge request reports