Skip to content

Add toast when pin item added and removed

Scott de Jonge requested to merge 424722-announce-when-nav-item-is-pinned-unpinned into master

What does this MR do and why?

When a nav-item is pinned/un-pinned there is no audible feedback to screen reader users. This change adds GlToast to provide visual and audible feedback when a nav-item is pinned/un-pinned.

Screenshots or screen recordings

Before After
CleanShot_2023-10-30_at_12.37.01 CleanShot_2023-10-30_at_12.33.27
CleanShot_2023-10-30_at_15.13.20 CleanShot_2023-10-30_at_15.14.19
CleanShot_2023-10-30_at_15.21.42 CleanShot_2023-10-30_at_15.22.51

How to set up and validate locally

  1. View new navigation with pinnable items e.g http://gdk.test:3000/flightjs/Flight/-/issues/6
  2. Toggle pinning/un-pinning items from: 3. An expanded menu section 4. A flyout menu 5. The pinned section menu
  3. All should provide a toast with "{title} has been added/removed to/from pinned items"

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Related to #424722 (closed)

Edited by Scott de Jonge

Merge request reports