Skip to content

Created additional states for merge request reviewer

Phil Hughes requested to merge ph/428089/reviewerRequestChangesBackend into master

What does this MR do and why?

This creates 1 extra state requested_changes for merge request reviewers. When a reviewers state is changed to requested_changes their approval gets removed.

With this change it also changes the behaviour of a normal comment, previously the reviewer would be set as reviewed however with this change when the user comments their state doesn't change. To update to a reviewed state the user has to use the review workflow.

UPDATE "merge_request_reviewers" SET "state" = 1 WHERE "merge_request_reviewers"."id" = 41

https://explain.depesz.com/s/IpUg

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

Before After

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

#428089 (closed)

Edited by Phil Hughes

Merge request reports