Skip to content

As an anonymous or non group member, group wikis are not searchable

Ravi Kumar requested to merge 423525-group-wikis-visibility-bug into master

What does this MR do and why?

This MR extracts the elastic_search logic for wikis from GitClassProxy to WikiClassProxy. I also added root_ancestor_ids in the GroupSearchResults to support routing search for the wiki for group search.

Also added group_id in the options for group search which has the value of the currently selected group for the search. I think group_ids in the options can either be removed or should be set to the user's authorized groups just like in the case of projects

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

Before After

How to set up and validate locally

Ensure elasticearch is enabled

  • Perform a Group Search as an anonymous user and verify that the public group's wikis and public subgroup's wikis are shown
  • Perform a Group Search as a logged in non-member user and verify that the public groups' wikis, internal groups' wikis, public subgroups' and internal subgroups' wikis are shown

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Related to #423525 (closed)

Edited by Ravi Kumar

Merge request reports