Skip to content

Cleanup table classes on import / pipelines pages

Justin Ho Tuan Duong requested to merge justin_ho-cleanup-table-classes-on-import-pages into master

What does this MR do and why?

Remove the useless overrides added with DEFAULT_TH_CLASSES on tables that already have GlTable styles.

Screenshots or screen recordings

Page Before After
Bulk import Bulk_import_table_before Bulk_import_table_after
Import history Project_import_history_before Project_import_history_after
Pipelines Pipelines_before Pipelines_after

How to set up and validate locally

Bulk import http://127.0.0.1:3000/import/bulk_imports/status

  1. In the header bar, click on + icon (Create new...) > New group.
  2. Select Import group.
  3. Fill in the GDK URL as GitLab source instance URL and a Person Access Token. Then click Connect instance.
  4. You should be on the Import groups from GitLab page.

Import history http://127.0.0.1:3000/import/history

  1. In the header bar, click on + icon (Create new...) > New project/repository.
  2. Select Import project.
  3. Click the History link on the further right.
  4. You should be on the Project import history page.

Pipelines http://127.0.0.1:3000/gitlab-org/gitlab-test/-/pipelines

Go to Project > Build > Pipelines on a project that already has at least 1 pipeline.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Relates to #362362 (closed)

Edited by Justin Ho Tuan Duong

Merge request reports