Skip to content

Fix dark mode label's "remove" button hover color

Chad Lavimoniere requested to merge 20231024-clavimoniere-darkmode-label-remove-hover-fix into master

What does this MR do and why?

This is a followup to #428092 (closed)

In dark mode, when the user hovers over the remove button on a label, the remove button is the opposite color. This MR fixes that.

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

Before After
Screenshot_2023-10-24_at_16.47.35 Screenshot_2023-10-24_at_16.48.22
Screenshot_2023-10-24_at_16.47.42 Screenshot_2023-10-24_at_16.48.29
Screenshot_2023-10-24_at_16.47.49 Screenshot_2023-10-24_at_16.48.36

How to set up and validate locally

  1. Check out this branch locally
  2. ensure dark mode is turned on
  3. navigate to an issue with labels
  4. hover over the remove button on any label; you should see that it remains the same color, but the svg changes

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Merge request reports