Resolve "Nav eval > Hamburger button insufficient contrast"
requested to merge gitlab-community/gitlab:427952-nav-eval-hamburger-button-insufficient-contrast into master
What does this MR do and why?
Adds correct contrasts for top header on hamburger, CSS rules were already set up but was not affecting the hamburger icon as it is a button not an anchor tag. Also added to GitLab-UI here: gitlab-ui!3772 (merged), it will need to be merged before this MR.
Screenshots or screen recordings
Screenshots are required for UI changes, and strongly recommended for all other merge requests.
| Before | After |
|---|---|
| Screen Recording 2023-11-02 at 16.55.29.mov | Screen Recording 2023-11-02 at 16.54.40.mov |
How to set up and validate locally
Numbered steps to set up and validate the change are strongly suggested.
- Ensure this feature flag is turned on :
Feature.enable(:super_sidebar_logged_out) - Open GDK while logged out (easiest if you just open the same page in incognito)
- narrow your window until the hamburger icon appears
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Related to #427952 (closed)
Edited by James Rushford