Skip to content

Fix Injections clashing with Computed for VUE 3 migration

Artur Fedorov requested to merge 428634-vue3-migration-injections-clashing into master

What does this MR do and why?

This MR fixes Injections clashing with Computed

Injection name and local state property has same alias, hence there is name collision. This MR fixed name collision

Resolves #428634 (closed)

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

*** NO VISUAL CHANGES ***

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

Numbered steps to set up and validate the change are strongly suggested.

  1. You can run script from parent epic on master, find
  22     [Vue warn]: Data property "targetAccessLevelOptions" is already defined in Inject.,
  21     [Vue warn]: Data property "userNamespaceId" is already defined in Inject.,
  15     [Vue warn]: Computed property "projectId" is already defined in Inject.,
  15     [Vue warn]: Computed property "prependedText" is already defined in Inject.,
  1. Checkout branch
  2. Run script again
  3. Make sure warning is gone

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Related to #428634 (closed)

Edited by Artur Fedorov

Merge request reports

Loading