Update some specs to pass with the super sidebar
What does this MR do and why?
Update some specs to pass with the super sidebar
This updates several specs to pass when the super sidebar is enabled.
In some cases, we were checking whether the correct nav item was marked as active in controller/request specs. These test cases have all been moved to a single feature spec as the Js driver needs to be enabled.
The have_active_navigation
and have_active_sub_navigation
custom
matchers have been updated to look for the right selectors in the super
sidebar. Using those matchers now requires the Js driver to be enabled
and should therefore be used in feature specs only.
Screenshots or screen recordings
No visual change.
How to set up and validate locally
bundle exec rspec ee/spec/controllers/projects/analytics/merge_request_analytics_controller_spec.rb
bundle exec rspec ee/spec/controllers/projects/security/api_fuzzing_configuration_controller_spec.rb
bundle exec rspec ee/spec/controllers/projects/security/sast_configuration_controller_spec.rb
bundle exec rspec ee/spec/features/boards/group_boards/multiple_boards_spec.rb
bundle exec rspec ee/spec/features/user_sees_active_nav_items_spec.rb
bundle exec rspec ee/spec/requests/projects/dependencies_controller_spec.rb
bundle exec rspec spec/features/boards/multiple_boards_spec.rb
bundle exec rspec spec/features/profiles/user_visits_profile_account_page_spec.rb
bundle exec rspec spec/features/profiles/user_visits_profile_authentication_log_spec.rb
bundle exec rspec spec/features/profiles/user_visits_profile_preferences_page_spec.rb
bundle exec rspec spec/features/profiles/user_visits_profile_spec.rb
bundle exec rspec spec/features/profiles/user_visits_profile_ssh_keys_page_spec.rb
bundle exec rspec spec/features/projects/user_uses_shortcuts_spec.rb
bundle exec rspec spec/features/user_sees_active_nav_items_spec.rb
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.