UI text: clarify language about dependencies
What does this MR do?
#356017 (closed) raised concerns that the message in the merge widget was unclear about how to fix dependencies. This MR tries to craft a clearer, more complete message. It is, however, a bit longer...
- Old:
Merge blocked: all merge request dependencies must be merged.
- New:
Merge blocked: all dependent merge requests must be removed or merged.
I don't love the word removed
here, because it kinda implies that the merge request itself is being removed. That's not the case. I wonder if the phrase unlinked or merged
is a better approach? We use remove
in https://docs.gitlab.com/ee/user/project/merge_requests/dependencies.html though.
Thoughts? Some extra options:
Merge blocked: all merge request dependencies must be removed or merged.
Merge blocked: all dependent merge requests must be unlinked or merged.
Merge blocked: merge all dependent merge requests, or remove them as dependencies.
Related issues
Closes Clarify that closed MRs as dependencies still b... (#356017 - closed)
Author's checklist
-
Optional. Consider taking the GitLab Technical Writing Fundamentals course. -
Follow the: -
If you're adding or changing the main heading of the page (H1), ensure that the product tier badge is added. -
If you are a GitLab team member, request a review based on: - The documentation page's metadata.
- The associated Technical Writer.
If you are a GitLab team member and only adding documentation, do not add any of the following labels:
~"frontend"
~"backend"
~"type::bug"
~"database"
These labels cause the MR to be added to code verification QA issues.
Reviewer's checklist
Documentation-related MRs should be reviewed by a Technical Writer for a non-blocking review, based on Documentation Guidelines and the Style Guide.
If you aren't sure which tech writer to ask, use roulette or ask in the #docs Slack channel.
-
If the content requires it, ensure the information is reviewed by a subject matter expert. - Technical writer review items:
-
Ensure docs metadata is present and up-to-date. -
Ensure the appropriate labels are added to this MR. -
Ensure a release milestone is set. - If relevant to this MR, ensure content topic type principles are in use, including:
-
The headings should be something you'd do a Google search for. Instead of Default behavior
, say something likeDefault behavior when you close an issue
. -
The headings (other than the page title) should be active. Instead of Configuring GDK
, say something likeConfigure GDK
. -
Any task steps should be written as a numbered list. - If the content still needs to be edited for topic types, you can create a follow-up issue with the docs-technical-debt label.
-
-
-
Review by assigned maintainer, who can always request/require the reviews above. Maintainer's review can occur before or after a technical writer review.