Skip to content

Fix save password form dialog on CI/CD Registration token

Sascha Eggenberger requested to merge runners-registration-token-ff-pw-fix into master

What does this MR do and why?

Fixes a bug where in Firefox the save password dialog appears when visiting the CI/CD project settings page.

Screenshots or screen recordings

Before After
cicd_before cicd_after

How to set up and validate locally

  1. Use Firefox with Ask to save logins and passwords for websites setting enabled
  2. http://gdk.test:3000/flightjs/Flight/-/settings/ci_cd
  3. Navigate to another page
  4. Check functionality of Runners > Project runner registration token

Issue

The culprit is the Project runner registration token form in the dropdown as it switches the field from password to text depending it's state. When it's hidden it's a password which forces FF to believe it should show the save password dialog.

error

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Closes #427896 (closed)
Related to #425468 (closed)

Edited by Sascha Eggenberger

Merge request reports