Skip to content

Fix more specs to run properly in the super sidebar

Lukas Eipert requested to merge leipert-fix-more-sidebar-specs into master

What does this MR do and why?

Move Unsubscribe Links spec to super sidebar nav

The spec doesn't need any other changes.

Move issues quick action spec to super sidebar

No other changes were needed.

See: #420121 (closed)

Make Session TTL spec work with super sidebar

Apparently the specs had side-effects on each other. By expiring all sessions before each spec, we were able to make the specs pass order-independent.

Remove obsolete snippets related spec file

In the old nav links to public snippets worked like this:

  1. "Your work" sidebar if logged in
  2. No sidebar if logged-out

In the new nav they are "Your work" and "Explore" respectively. This behaviour is tested in spec/features/snippets/show_spec.rb, so we can remove this spec.

Screenshots or screen recordings

No visible changes

How to set up and validate locally

N/A

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Lukas Eipert

Merge request reports

Loading