Show loading icon in vulnerability status badge
What does this MR do and why?
Show loading icon in status badge on the vulnerability details page.
This improves layout shift and brings some continuity by keeping the status badge visible, but displaying a loading icon within in when the vulnerability state is updating.
Related to #429632 (closed)
Screenshots or screen recordings
Screenshots are required for UI changes, and strongly recommended for all other merge requests.
Before | After |
---|---|
before-status-badge | after-status-badge |
How to set up and validate locally
Prerequisites
- You need an EE license
- You need to have runners enabled (See $2408961 for setting up a runner)
- Import https://gitlab.com/gitlab-examples/security/security-reports
- Run a pipeline on master
Validation
- Go to security reports vulnerability report and click on one of the vulnerabilities
- Change the state with the top-right state dropdown and watch the status badge load and change state + color
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Edited by Lorenz van Herwaarden