Draft: Unbox activity notes
What does this MR do and why?
Unboxes the top level comments (notes) but keeps the "boxyness" for threaded comments:
- Unboxes top level comments (notes)
- Keeps replies "boxed"
- Evens spacings between system activities and user comments
- Unifies the "edited" text appearance
- Bonus: Simplifies CSS used quite a bit (tech debt)
This would still benefit from a CSS rewrite/adjustment as a follow-up measure.
Screenshots or screen recordings
Issuables
Before | After |
---|---|
Epics
Before | After |
---|---|
MRs
Before | After |
---|---|
MR diff view
Before | After |
---|---|
Work items
Before | After |
---|---|
Alignment
Vertical alignment |
---|
How to set up and validate locally
- Go to an issue (e.g. http://gdk.test:3000/flightjs/Flight/-/issues/3)
- Go to an epic (e.g. http://gdk.test:3000/groups/flightjs/-/epics/5)
- Go to an MR (e.g. http://gdk.test:3000/flightjs/Flight/-/merge_requests/3)
- Go to an MR diff view (e.g. http://gdk.test:3000/flightjs/Flight/-/merge_requests/3/diffs)
- Go to an Work item [Task/Objective/Key result] (e.g. http://gdk.test:3000/flightjs/Flight/-/work_items/49)
- Go to an commit (e.g. http://gdk.test:3000/flightjs/Flight/-/commit/f3d5120015b8286a5fbef20e78a8daa46524e3b7)
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Related to ✂️ UX Paper Cuts 16.6 → Activity (#425468 - closed), #424396 (closed)
Edited by Sascha Eggenberger