Skip to content

Database fixes for Rails 7.1 that can be extracted into default branch

Igor Drozdov requested to merge id-rails-7.1-small-database-fixes into master

What

  • Set correct inverse_of to epic->epic_board_positions
  • Stub table_exists? for schema_migration
  • Fix deprecation warnings related to database
  • Fix the migrations patch
  • Specify main explicitly for database hash config
  • Fix spec/lib/gitlab/database/transaction/observer_spec.rb
  • Fix spec/lib/gitlab/database/with_lock_retries_spec.rb
  • Fix ee/spec/services/ee/issuable/destroy_service_spec.rb
  • Fix ee/spec/models/ee/group_spec.rb
  • Fix ee/spec/services/deployments/approval_service_spec.rb
  • Fix Gitlab::Database.gitlab_schemas_for_connection method
  • Fix db/validate_config.rake for single-db config

Why

These database-related changes fix the tests in Draft: Upgrade Rails to 7.1.1 version (!124004 - closed); however, they can be extracted to make the diff of the MR smaller. Most of them are spec changes and are considered safe.

The commits can be squashed on merge

Edited by Igor Drozdov

Merge request reports