Fix Google reCAPTCHA form submit button not visible in pipelines CC form
What does this MR do and why?
This MR resolves #378041 (closed).
To accommodate Google reCAPTCHA challenge form, the height of the iframe is set to 480px. Without doing this, the iframe height is insufficient to display the challenge form in its entirety and the submit button of the form is not visible to the user and cannot be clicked.
Screenshots or screen recordings
Before | After |
---|---|
How to set up and validate locally
-
Set up Customers app. Ensure you have
zuora_payment_method_validation_page_id
configured to an HPM form with captcha enabled -
Start GDK with
SIMULATE_GITLAB_SAAS=1
-
To make things easier, update
User#requires_credit_card?
to# ee/app/models/ee/user.rb def requires_credit_card?(project) return true end
-
Login
root
(make sure it has no associatedUsers::CreditCardValidation
record), go to http://localhost:3000/flightjs/Flight/-/pipelines/new, set the branch to anything other thanmaster
then clickRun pipeline
-
You should see "User validation required" alert
-
Click on "Validate account", click on the Google reCAPTCHA checkbox
-
Validate that you can see the entirety of the challenge form
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.