Skip to content

Fix SLO violation on llm_completion metric

Shinya Maeda requested to merge fix-slo-violation-llm_completion into master

What does this MR do and why?

This MR fixes SLO violation on llm_completion metric. https://dashboards.gitlab.net/d/sidekiq-main/sidekiq3a-overview?orgId=1&from=now-2d&to=now&viewPanel=3924591239

!135920 (merged) changed the response in Completions::SummarizeMergeRequest to be nil when the diff is too big. This is considered as an error in the Llm::CompletionWorker due to response.try(:errors)&.empty?.

Fixes gitlab-com/gl-infra/production#17102 (closed)

See https://gitlab.slack.com/archives/C064WMDEQE7/p1699496933150329 for more information

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

Before After

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Shinya Maeda

Merge request reports

Loading