Skip to content

Add guidance on prefixing tokens

Nick Malcolm requested to merge nmalcolm-master-patch-352d into master

What does this MR do and why?

We do not have guidance on our token prefix strategy. We add new secrets to our application for time to time, and we also update existing secret generation to prefix tokens. Standardising our approach will lead to predictable token prefixes, and ensure this is communicated / updated in the relevant locations.

For example, I added gloas in Prefixes OAuth Application Secrets with gloas (!131601 - merged) but didn't know to add it to https://gitlab.com/gitlab-org/gitlab/-/tree/master/gems/gitlab-secret_detection

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

Before After

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Merge request reports

Loading