Do not truncate LDAP filter used to populate group membership
What does this MR do and why?
do not truncate LDAP filter used to populate group membership
Users with long filters want to see the whole filter, or else it is difficult to find errors in it.
The truncate function also introduced an unwanted double-encoding for & (I did not dig into this), HAML does this on its own so it is not needed.
Fixes issue #343450 (closed)
Screenshots or screen recordings
Screenshots are required for UI changes, and strongly recommended for all other merge requests.
Before | After |
---|---|
How to set up and validate locally
Numbered steps to set up and validate the change are strongly suggested.
- Visit any group page.
- Click
Settings > LDAP Synchronization
- Add new LDAP user filter longer than 70 characters.
- See that the filter is truncated everywhere in the webui when the patch is not applied.
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Edited by Kjetil Torgrim Homme