Skip to content

Fixed bug where reviewers approval state would not get reset

Phil Hughes requested to merge ph/fixReviewStateNotBeingResetOnPush into master

What does this MR do and why?

Fixes a bug where the merge request reviewers state would not get reset after the merge request gets a change push and the project has remove approvals setting on.

Screenshots or screen recordings

How to set up and validate locally

  • Enable mr_request_changes
  • Turn on Remove all approvals setting under project -> merge request settings
  • Create a merge request
  • Approve
  • Push a new change
  • Wait X+ seconds for approval to reset
  • Reviewers state should show as unreviewed

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Merge request reports