Skip to content

Creates reusable popover for security policies

Artur Fedorov requested to merge 431880-policies-reusable-popover into master

What does this MR do and why?

This MR creates reusable component and replaces three similar popovers:

  1. ee/app/assets/javascripts/security_orchestration/components/policy_editor/scan_execution/action/custom_section_tooltip.vue
  2. ee/app/assets/javascripts/security_orchestration/components/policy_editor/scope/compliance_framework_tooltip.vue
  3. ee/app/assets/javascripts/security_orchestration/components/policy_editor/scan_execution/action/scan_filters/runner_tags_list.vue

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

NO VISUAL CHANGES

Before After
custom_section_tooltip Screenshot 2023-11-17 at 01.25.45.png
compliance_framework_tooltip Screenshot 2023-11-17 at 01.25.36.png
runner_tags_list Screenshot 2023-11-17 at 01.25.23.png

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

Feature.enable(:compliance_pipeline_in_policies)
Feature.enable(:security_policies_policy_scope)
  1. Go to Group
  2. Security -> Policies -> new policy -> new scan execution policy
  3. Policy scope section on top for compliance_framework_tooltip
  4. Add new action Execute Yaml code block, you will see custom_section_tooltip
  5. runner_tags_list, make sure you have no tags for a group, Select has specific tag in runner tag section and hover over listbox

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Related to #431880 (closed)

Merge request reports

Loading