Require gitaly_address instead of path in storage settings
What does this MR do and why?
Requiring path in this context is a bit confusing because gitlab-rails does not actually determine where repositories are stored, gitaly does. Omnibus tends to hide this fact by using the same settings to configure gitaly and to configure gitlab-rails.
So here we begin to untangle this configuration by ensuring that gitlab-rails has the configuration that it needs.
Changelog: changed
How to set up and validate locally
- Edit
config/gitlab.yml
and remove allpath:
inproduction.repositories
(nottest.repositories
).## Repositories settings repositories: storages: # You must have at least a `default` storage path. default: gitaly_address: unix:/home/james/src/gitlab-org/gdk/gitaly.socket gitaly-1: gitaly_address: unix:/home/james/src/gitlab-org/gdk/gitaly.socket
- Restart gdk
$ gdk restart
- Try and view/clone repositories. Everything should still work.
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Edited by James Fargher