Skip to content

Fix offsets used for requesting last commit data

Jerry Seto requested to merge 415711-fix-logs-tree-loading into master

What does this MR do and why?

Fix offsets used for requesting last commit data

Tree entries for submodules are rendered before blobs but blobs are earlier in the pagination. This difference lead to an absence of submodule data with blob data being requested instead.

This change is to make requests to the logs_tree endpoint while taking into account this difference.

More details here: #415711 (comment 1661438606)

Screenshots or screen recordings

Before After
Screenshot_2023-11-23_at_1.25.13_PM Screenshot_2023-11-23_at_1.25.56_PM

How to set up and validate locally

  1. Create a project with more than total of 25 directories and files in the root directory
  2. Add a submodule to the project
  3. From the project overview (e.g http://gdk.test:3000/root/lots_of_files_and_directories) scroll down and see that the last commit for the submodule loads

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Related to #415711 (closed)

Edited by Jerry Seto

Merge request reports

Loading