Skip to content

Draft: Refactor catalog resources resolver and related methods

Leaminn Ma requested to merge refactor-catalog-resources into master

What does this MR do and why?

This is a follow up to !137015 (merged) in order to address and discuss the following suggestions:

  • @furkanayhan started a discussion: (+1 comment)

    Since all these parameters are optional, then why scope: is required in this method but others not?

  • @furkanayhan started a discussion: (+1 comment)

    Actually, we send all parameters all the time, so they are not optional anymore.

  • @furkanayhan started a discussion: (+1 comment)

    Does this mean scope == :all?

The intention is to merge this after or integrate it as part of !137596 (closed).

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Leaminn Ma

Merge request reports

Loading