Skip to content

MR widget: remove double border Part II

Sascha Eggenberger requested to merge mr-widget-double-border-part-2 into master

What does this MR do and why?

This is a follow-up to MR widget: remove double border (!137748 - merged)

It was reported by @danmh that in some edge cases we still render a double border (with the outer and inner layer having a border).
This is a boring solution to adress this issue more generally instead of targeting all those edge cases (there can be a lot).

Also fixes a wrongly set border-radius on the second element 👀

Screenshots or screen recordings

Before After
before after

How to set up and validate locally

As I wasn't able to reproduce this locally with any of my setups here is a manual process to test this:

  1. Go to gitlab-org/gitlab-services/design.gitlab.com!3625 (merged)
  2. Use this custom code
.mr-state-widget .mr-widget-section:not(:first-child)>div,
.mr-state-widget .mr-widget-section:not(:first-child)>section,
.mr-state-widget .mr-widget-section .mr-widget-section>div:not(:first-child) {
  margin-top: -1px;
}

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Related to !137748 (merged), #430244 (closed)

Edited by Sascha Eggenberger

Merge request reports