Skip to content

CI: Fail rubocop job on MRs when `RUN_ALL_RUBOCOP=true`

Peter Leitzen requested to merge pl-ci-rubocop-silenced-offenses-in-mrs into master

What does this MR do and why?

Previously, rubocop job would only silence offenses - and not fail - on MRs which potentially added them.

This behavior introduces new silenced offenses which are later reported in Slack channel via scheduled pipeline.

This commit ensures that the rubocop job fails on the MRs which introduced the offenses.

Refs

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Peter Leitzen

Merge request reports

Loading