Skip to content

Added shortcut to check "viewed" on MR-changes

Flo S requested to merge gitlab-community/gitlab:327153-added-shortcut-diffs-changes into master

What does this MR do and why?

Added shortcut to check "viewed" on MR-changes

This ticket #327153 describes the problem quite well:

  • be able to use a short cut "V" to check the checkbox "Viewed"
  • auto-close the file viewed
  • be able to un-check again via shortcut
  • added the shortcut to the tooltip

Changelog: changed

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

How to set up and validate locally

  1. create a MR with changes
  2. go to the changes tab
  3. press "v" on your keyboard

expected:

  • the checkbox "viewed" is checked
  • the file auto collapses
  • I can navigate with j and k to other files

actual:

  • there is no shortcut
  • when I press the checkbox with the mouse the focus is trapped and therefor
  • I can NOT navigate with j and k to other files

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Related to #327153

Edited by Flo S

Merge request reports