Protected containers: Rename column container_path_pattern
requested to merge gitlab-community/gitlab:424367-protected-containers-add-basic-model-and-migration-for-protecting-container-follow-up-rename-container-path-pattern into master
What does this MR do and why?
- This change was suggested by @10io and @jagood in !135969 (comment 1663923348)
- Renaming database column and model attribute
container_path_pattern
torepository_path_pattern
to use consistent naming in the context of the container registry - Following the guideline for renaming the column as described here: https://docs.gitlab.com/ee/development/database/avoiding_downtime_in_migrations.html#renaming-columns
Screenshots or screen recordings
This MR contains only database -related changes
How to set up and validate locally
- Run migration
rails db:migrate
- Run test to verify that everything works as expected
bundle exec rspec spec/graphql/types/container_registry/protection/rule_type_spec.rb spec/models/container_registry/protection/rule_spec.rb spec/requests/api/graphql/mutations/container_registry/protection/rule/create_spec.rb spec/services/container_registry/protection/create_rule_service_spec.rb
Todos
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR. -
Changelog entry added, if necessary -
Documentation created/updated via this MR -
Documentation reviewed by technical writer or follow-up review issue created -
Tests added for this feature/bug -
Tested in all supported browsers -
Conforms to the code review guidelines -
Conforms to the merge request performance guidelines -
Conforms to the style guides -
Conforms to the javascript style guides -
Conforms to the database guides
-
Related to #424367 (closed)
Edited by Gerardo Navarro