Stop Inline Findings Polling when error occurred
What does this MR do and why?
This commit fixes: #432895 (closed) It fixes a bug that would cause an Endless poll when the Inline Findings Query would error out.
Screenshots or screen recordings
Before | After |
---|---|
2023-11-28_15-30-26 | 2023-11-28_15-36-38 |
How to set up and validate locally
- Enable
sast_reports_in_inline_diff
- Make sure your running an ultimate license or your GDK (how to)
- Clone this repo: https://gitlab.com/jannik_lehmann/sast-inline-findings-example
- Recreate this MR for SAST & CodeQuality findings: jannik_lehmann/cq-and-sast-test!5 (diffs)
- Let the pipeline finish and the go checkout the diff page.
- apply the patch below to recreate a response error
diff --git a/app/assets/javascripts/diffs/components/graphql/get_mr_codequality_and_security_reports.query.graphql b/app/assets/javascripts/diffs/components/graphql/get_mr_codequality_and_security_reports.query.graphql
index bd8f408f5a14..c9a544ef19db 100644
--- a/app/assets/javascripts/diffs/components/graphql/get_mr_codequality_and_security_reports.query.graphql
+++ b/app/assets/javascripts/diffs/components/graphql/get_mr_codequality_and_security_reports.query.graphql
@@ -1,6 +1,6 @@
query getMRCodequalityAndSecurityReports($fullPath: ID!, $iid: String!) {
project(fullPath: $fullPath) {
- id
+ idsss
mergeRequest(iid: $iid) {
id
title
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Edited by Jannik Lehmann